Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpr/crc32c] Update version #13678

Merged
merged 6 commits into from
Oct 13, 2020
Merged

[cpr/crc32c] Update version #13678

merged 6 commits into from
Oct 13, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Sep 23, 2020 •
edited
Loading

Continue PR #13558.
Special changes:

  • crc32: set it always build as a static library instead of set CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS to ON.

Related: #13536.

@JackBoosY JackBoosY added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Sep 23, 2020
@JackBoosY JackBoosY changed the title [manyports] Update version 4 [cpr/crc32c/devil] Update version Sep 23, 2020
@JackBoosY JackBoosY changed the title [cpr/crc32c/devil] Update version [cpr/crc32c] Update version Sep 23, 2020
@JackBoosY JackBoosY requested review from PhoebeHui and NancyLi1013 and removed request for PhoebeHui September 23, 2020 08:32
@JackBoosY JackBoosY assigned NancyLi1013 and unassigned PhoebeHui Sep 23, 2020
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2020
ras0219-msft
ras0219-msft requested changes Sep 24, 2020
View reviewed changes
ports/devil/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 removed the info:reviewed Pull Request changes follow basic guidelines label Sep 25, 2020
JackBoosY
JackBoosY commented Sep 25, 2020
View reviewed changes
ports/devil/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor Author

Blocked by #13722.

@JackBoosY
Copy link
Contributor Author

blocked by #13765.

ras0219-msft
ras0219-msft requested changes Sep 28, 2020
View reviewed changes
ports/devil/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Oct 9, 2020
@BillyONeal BillyONeal merged commit 26279b7 into microsoft:master Oct 13, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@JackBoosY JackBoosY deleted the dev/jack/manyports_20200923_3 branch October 14, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JackBoosY @BillyONeal @ras0219-msft @NancyLi1013 @PhoebeHui